Skip to content

Don't let Column.name be None #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

MarcoGorelli
Copy link
Contributor

Noticed this while updating the polars implementation: their series must have a str name, and can't be None

We could hack around this in the implemenation, but I think it's easier to just require the name to only be str

Afterall:

  • if a column is created from a dataframe (e.g. df.get_column_by_name('foo')), then its name will be the column name (which has to be str)
  • if a column is constructed from a sequence or 1d array, then we can require that a str name be specified

So, name will always be str

@MarcoGorelli MarcoGorelli merged commit 192901a into data-apis:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants